-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Command implementation #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfigureOptionsFromInput
asgrim
force-pushed
the
build-implementation
branch
from
July 10, 2024 11:22
2ba97dd
to
0c787f6
Compare
theofidry
reviewed
Jul 10, 2024
asgrim
commented
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3
I'm going to merge this one fairly soon, as it isn't a huge add. Assuming there is no show-stoppers, I'll probably merge end of this week, or beginning of next, just in case anyone wants to give any further feedback.
Are you an end user who would like to try this out?
Please note that this is just an initial implementation, and will only download and build an extension to a temporary path on your machine; it will not install anything just yet. That is coming soon!
If you understand, and you'd still like to help test this...
Primarily the best way to provide feedback here as an end user of PIE is to check the
build
command works on your machine! You can do that by following these steps (please adjust for your platform differences of course!)asgrim/example-pie-extension
is intentionally only compatible with PHP 8.3)git clone -b download-implementation https://github.com/asgrim/pie.git
composer install
bin/pie build asgrim/example-pie-extension
You should see something like:
Are you an extension maintainer who would like to try this out?
It's not strictly necessary to support this just yet, but if you're keen, and please note, things may change before we finally release PIE... so you do this at your own risk. Note: at the moment, you will need to make a new release - see ThePHPF/pie-design#17
composer.json
to your repo - example here https://github.com/asgrim/example-pie-extension/blob/main/composer.jsonalpha
release is fine, e.g.1.2.3-alpha.
) - note, "branches" or "commits" are not yet supported - see Add support fordev-main
anddev-main#sha
type version requests #13composer.json
automatically and understand that it is aphp-ext
orphp-ext-zend
, it should appear in https://packagist.org/extensions once addedMore details, for example for help on
composer.json
, can be read in https://github.com/ThePHPF/pie-design?tab=readme-ov-file#extension-maintainer-register-a-pie-package