Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Command implementation #19

Merged
merged 15 commits into from
Jul 22, 2024
Merged

Build Command implementation #19

merged 15 commits into from
Jul 22, 2024

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Jul 10, 2024

Fixes #3

I'm going to merge this one fairly soon, as it isn't a huge add. Assuming there is no show-stoppers, I'll probably merge end of this week, or beginning of next, just in case anyone wants to give any further feedback.

Are you an end user who would like to try this out?

Please note that this is just an initial implementation, and will only download and build an extension to a temporary path on your machine; it will not install anything just yet. That is coming soon!

If you understand, and you'd still like to help test this...

Primarily the best way to provide feedback here as an end user of PIE is to check the build command works on your machine! You can do that by following these steps (please adjust for your platform differences of course!)

  • Ensure you are using PHP 8.3 (this is because my test extension asgrim/example-pie-extension is intentionally only compatible with PHP 8.3)
  • git clone -b download-implementation https://github.com/asgrim/pie.git
  • composer install
  • bin/pie build asgrim/example-pie-extension
  • Let me know if you encounter any errors or something unexpected!

You should see something like:

$ bin/pie build asgrim/example-pie-extension
You are running PHP 8.3.8
Target PHP installation: 8.3.8 nts, on Linux/OSX/etc x86_64 (from /usr/bin/php8.3)
Found package: asgrim/example-pie-extension:1.0.1 which provides ext-example_pie_extension
phpize complete.
Configure complete.
Build complete.

Are you an extension maintainer who would like to try this out?

It's not strictly necessary to support this just yet, but if you're keen, and please note, things may change before we finally release PIE... so you do this at your own risk. Note: at the moment, you will need to make a new release - see ThePHPF/pie-design#17

More details, for example for help on composer.json, can be read in https://github.com/ThePHPF/pie-design?tab=readme-ov-file#extension-maintainer-register-a-pie-package

@asgrim asgrim added the enhancement New feature or request label Jul 10, 2024
@asgrim asgrim self-assigned this Jul 10, 2024
@asgrim asgrim changed the title Build implementation Build Command implementation Jul 10, 2024
@asgrim asgrim force-pushed the build-implementation branch from 2ba97dd to 0c787f6 Compare July 10, 2024 11:22
@asgrim asgrim marked this pull request as ready for review July 10, 2024 13:15
@asgrim asgrim merged commit 2dc77ac into php:main Jul 22, 2024
13 checks passed
@asgrim asgrim deleted the build-implementation branch July 22, 2024 14:56
@asgrim asgrim added this to the 0.1.0 - initial release milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder command & related components
2 participants