Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font icon swapping #184

Merged
merged 6 commits into from
Sep 1, 2024

Conversation

iMattPro
Copy link
Contributor

@iMattPro iMattPro commented Sep 1, 2024

No description provided.

iMattPro added 5 commits July 28, 2024 14:00
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>

# Conflicts:
#	.github/workflows/tests.yml
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (009456e) to head (9e0ecda).
Report is 11 commits behind head on dev/4.0.

Files with missing lines Patch % Lines
controller/admin_controller.php 0.00% 1 Missing ⚠️
ext.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/4.0     #184      +/-   ##
=============================================
- Coverage      67.21%   67.07%   -0.15%     
- Complexity       206      207       +1     
=============================================
  Files             14       14              
  Lines            729      741      +12     
=============================================
+ Hits             490      497       +7     
- Misses           239      244       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matt Friedman <[email protected]>
@iMattPro iMattPro merged commit 1deee23 into phpbb-extensions:dev/4.0 Sep 1, 2024
32 checks passed
@iMattPro iMattPro deleted the font-icon-stuff branch September 1, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants