-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] unittests with travis #66
base: master
Are you sure you want to change the base?
Conversation
To simplify things I proposed the easier way of life here: ClemensSahs#1 What do you think? |
@@ -2,7 +2,7 @@ | |||
# For more see: https://github.com/mojombo/jekyll/wiki/Permalinks | |||
permalink: /:categories/:year/:month/:day/:title | |||
|
|||
exclude: [".rvmrc", ".rbenv-version", "README.md", "Rakefile", "changelog.md"] | |||
exclude: [".rvmrc", ".rbenv-version", "README.md", "Rakefile", "changelog.md","vendor"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this vendor
directory contain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this we need to fix the building error
bundle exec rake travis
or easier bundle exec jekyll serve --detach --port 4000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question is, if we can get rid of this change when we killed grunt and npm? I would like to know who (which script) creates this dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sry for write this unclear.
this directory will create by bundle install --deployment
Generating... Error reading file /home/travis/build/ClemensSahs/phpughh.github.com/vendor/bundle/ruby/1.9.1/gems/RedCloth-4.2.9/spec/fixtures/lists.yml: Don't know how to add to a NilClass!
This we need to build the the page with jekyll serve
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, right. Then it have to stay obviously 🐳
@Nesquick I will look how we can hide the requested URL's else we have with 10 tests N log lines in travis. |
great. So lets see how this PR looks like when this ClemensSahs#1 is merged - I guess we are good to go then. Just addings some docs and beautify the output |
any updates here @ClemensSahs? |
remove unneccessary modules and installers
sry guy's I was very busy the last weeks. Now I have some more time.
I think the request URI come from phantomjs, currently I have no solution for that. Has somebody a idea? |
@ClemensSahs could you please again just post the url for us? :) |
issue #25
todo