Migrate nodesource to new repository #375
Conversation
|
looks like github actions docker infra is currently mega broken, ping me again after a while so i remember to re-run the tests. |
|
That might be part of it but docker can't pull |
| @@ -4,8 +4,13 @@ source /pd_build/buildconfig | |||
| set -x | |||
|
|
|||
| echo "+ Enabling Node Source APT repo" | |||
| curl -sL https://deb.nodesource.com/setup_18.x | bash - | |||
There was a problem hiding this comment.
no longer using the script, but still fetching from the same source. just more manually... hmm
image/nodejs.sh
Outdated
| mkdir -p /etc/apt/keyrings | ||
| curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | sudo gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg | ||
| echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_MAJOR}.x nodistro main" | sudo tee /etc/apt/sources.list.d/nodesource.list | ||
| sudo apt-get update |
There was a problem hiding this comment.
sudo is not available/needed and can be removed in all of the above.
image/nodejs.sh
Outdated
| apt-get update | ||
| NODE_MAJOR=18 | ||
| sudo apt-get update | ||
| sudo apt-get install -y ca-certificates curl gnupg |
There was a problem hiding this comment.
ca-certiifaces and curl are already installed. gpg executable appears to be already available via the gpg package. Works for me without those two lines. Maybe they can be removed to simplify the script?
|
closing in favour of #376 |
I've knocked together an (untested) PR for #374 in the hope that it might be of use
The code is based on nodesource's migration guide; https://github.com/nodesource/distributions/wiki/How-to-migrate-to-the-new-repository