Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If provided lighttpd will bind to ServerIPv6 in host mode #543

Closed
wants to merge 3 commits into from

Conversation

jnss95
Copy link

@jnss95 jnss95 commented Dec 10, 2019

Description

Bugfix of Issues #163 and #239

Motivation and Context

Since I am already running a nginx instance on Port 80 on my machine, I wanted to bind pihole onto a different pair of IP addresses.
This worked fine for IPv4 using the ServerIP environment variable, but failed for IPv6 because lighttpd still tried to bind to [::].

How Has This Been Tested?

Tested on Ubuntu Server 18.40 running Docker 19.03.5 on an AMD64 host system.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@diginc
Copy link
Collaborator

diginc commented Jan 2, 2020

If you pull in the latest code from dev branch it should resolve the CI test failures (and switch from travis to Circle CI)

@jnss95
Copy link
Author

jnss95 commented Jan 4, 2020

If you pull in the latest code from dev branch it should resolve the CI test failures (and switch from travis to Circle CI)

Done

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the stale label Jan 19, 2023
@github-actions
Copy link

Existing merge conflicts have not been addressed. This PR is considered abandoned.

@github-actions github-actions bot closed this Jan 19, 2023
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/support-changing-admin-bind-address-to-something-else-than-ftlconf-local-ipv4/60632/21

@PromoFaux
Copy link
Member

@Xeranor - sorry this kind of fell by the wayside - would you like to bring it up to date with the latest changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants