Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hidden column to the network table to allow filtering by hostnames #3264

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

rdwebdesign
Copy link
Member

@rdwebdesign rdwebdesign commented Feb 28, 2025

What does this PR aim to accomplish?

This PR restores v5 functionality, allowing users to filter the Network table using hostnames.

The v5 table had a hostname column, allowing datatables to use the values on this column to filter the table.
In v6 this column was merged with IP column; The hostnames are dynamically added to the first cell, but they are not searchable.

Issue originally reported on Discourse:
https://discourse.pi-hole.net/t/search-in-tools-network-not-searching-on-hostname-v6/77123

How does this PR accomplish the above?

Including a hidden column containing the hostnames allows datatables to use these values.

image

Note:
When saveState is true, datatables ignores visible: false and shows the column. If we set saveState: false we lose the ability to save properties like sort order, number of items per page, etc.

To solve this issue, we keep saveState: true and use class: "hide", to make sure the column will be hidden by CSS .hide class.

Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Note: using "hide" CSS class to hide the column even if datatables decides to show it

Signed-off-by: RD WebDesign <[email protected]>
@rdwebdesign rdwebdesign requested a review from a team February 28, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants