-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXPERIMENTAL!! jump table address decoder + support 24k and 32k drive roms #47
base: master
Are you sure you want to change the base?
Conversation
This is how VICE does it and it is cleaner. Just be careful though and make sure that everything is still mapped correctly. readNULL returning 0 will break a lot of copy protections. |
unmapped ram returns address >> 8
I’ve done the >>8 but closing for now - will re open when I look at cleaning it up properly |
added memory map shadows
Can you pls take another peek at this ? I’ve added support for 24k and 32k drive roms (like dolphin and sjiffy) |
This has merge conflicts with my PR #72 |
For review and discussion only at this stage..
It does work - by work I mean a d64copy works fine. I haven’t tested more yet.
What’s the best way to profile this ?
At the expense of a little ram, this should be quicker - certainly more predictable.
I’m no c++ dev, but maybe a MemoryDevice base class for the VIA, rom and ram would make this much cleaner. The intermediate functions are horrible.
The big advantage is zero additional run time overhead as we add more config options - additonal rom, ram, 1581, 1571 support and so forth