Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft CONTRIBUTING.md #8

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Draft CONTRIBUTING.md #8

merged 2 commits into from
Jun 29, 2018

Conversation

htjjen
Copy link
Contributor

@htjjen htjjen commented Jun 28, 2018

  • Add Introduction, Our Standards, and Attribution to CONTRIBUTING.md

Issue #5

CONTRIBUTING.md Outdated
* Be respectful and focus on what is the best for the community

## Attribution
Our standards are adapted from the [Contributor Covenant](https://www.contributor-covenant.org/version/1/4/code-of-conduct), version 1.4, available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.

This part is unnecessary since you already provided a link, feel free to remove.

@pianobin
Copy link
Owner

Hey @htjjen, could you make this small change? Thanks again!

@htjjen
Copy link
Contributor Author

htjjen commented Jun 29, 2018

Thank you for reviewing it! I've made the change and submit a new PR.

@pianobin
Copy link
Owner

Looks good, merging!

@pianobin pianobin merged commit 2e638b5 into pianobin:master Jun 29, 2018
@htjjen
Copy link
Contributor Author

htjjen commented Jun 29, 2018

Thank you for the opportunity!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants