Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure LazyTableReference isn't resolved until referenced table has been initialised #758

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

make sure LazyTableReference isn't resolved until referenced table has been initialised #758

wants to merge 21 commits into from

Commits on Jan 31, 2023

  1. make sure LazyTableReference isn't resolved until referenced table … 

    …has been initialised
    @dantownsend
    dantownsend committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    5ec7a48 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. raise exception if LazyTableReference is resolved before ready

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0afc5a9 View commit details
    Browse the repository at this point in the history

  2. more robust checks for table readiness - using app name and module, a… 

    …s well as table class name
    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    074cf4a View commit details
    Browse the repository at this point in the history

  3. fix tests

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b571580 View commit details
    Browse the repository at this point in the history

  4. reduce repetition

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    889edb3 View commit details
    Browse the repository at this point in the history

  5. fix linter error

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e20f955 View commit details
    Browse the repository at this point in the history

  6. improve assertions

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    976b9a5 View commit details
    Browse the repository at this point in the history

  7. set_ready now returns the status

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    02602ad View commit details
    Browse the repository at this point in the history

  8. check_ready

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a49c901 View commit details
    Browse the repository at this point in the history

  9. fix tests

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    39c7d3d View commit details
    Browse the repository at this point in the history

  10. try getting table from TABLE_REGISTRY instead of using importlib 

    Using importlib could mean we get partially initialised modules
    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    4ff57c0 View commit details
    Browse the repository at this point in the history

  11. more explicit error message

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6f58db4 View commit details
    Browse the repository at this point in the history

  12. clean up some tests

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    d586190 View commit details
    Browse the repository at this point in the history

  13. change variable name

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    78af24a View commit details
    Browse the repository at this point in the history

  14. improve tests

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    af3d33d View commit details
    Browse the repository at this point in the history

  15. improve serialisation of lazy table references in migrations

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3787b7d View commit details
    Browse the repository at this point in the history

  16. missing code

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    61cb43b View commit details
    Browse the repository at this point in the history

  17. update the docs for LazyTableReference

    @dantownsend
    dantownsend committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7e31608 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Merge branch 'master' into 757-lazy-table-reference-sometimes-fails

    @dantownsend
    dantownsend committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3c63721 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Merge branch 'master' into 757-lazy-table-reference-sometimes-fails

    @dantownsend
    dantownsend committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    30dbaa0 View commit details
    Browse the repository at this point in the history

  2. rename SetReadyResponse -> CheckReadyResponse

    @dantownsend
    dantownsend committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0bd1f12 View commit details
    Browse the repository at this point in the history