Simplify create_pydantic_model
#892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: skelmis <[email protected]>
* support Postgres 16 * remove Postgres 10
I didn't like how it was overriding `format` on the JSON schema. All of the custom values we add to the JSON schema are now namespaced under the `extra` key. It makes things much less confusing and more maintainable.
dantownsend
added a commit
that referenced
this pull request
Oct 20, 2023
* pydantic v2 support (#866) * pydantic v2 support based off master...sinisaos:piccolo:pydanticV2_test by @sinisaos * add more schema attributes for Piccolo Admin compatibility * use newer fastapi in asgi template * fix indentation in docstring * update docs * add docs for v1 * fixed typo in version number, `0.108` -> `0.118` * fix link * use `model_validate_json` instead of `parse_raw` * fix deprecation warnings for `dict` method * improve pydantic version specifier * run tests on v1 branch * bumped version * fix banner link * fix typo in link * Simplify `create_pydantic_model` (#892) * Merge pull request from GHSA-h7cm-mrvq-wcfr Co-authored-by: skelmis <[email protected]> * bumped version * fix typo * Support Postgres 16 (#886) * support Postgres 16 * remove Postgres 10 * simplify `create_pydantic_model` I didn't like how it was overriding `format` on the JSON schema. All of the custom values we add to the JSON schema are now namespaced under the `extra` key. It makes things much less confusing and more maintainable. * fix tests --------- Co-authored-by: skelmis <[email protected]> * bumped version * update docs --------- Co-authored-by: skelmis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifying
create_pydantic_modelfor v1.The main thing is all additional fields added to the JSON schema are namespaced under
extra.This makes things a lot easier to understand, and means we're less likely to clash with anything in JSON schema in the future.