Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce progress bar updates #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sh1n1g4m1
Copy link

Change progress bar to only update on integer changes, this prevents excessive database writes.

@lukevp
Copy link

lukevp commented Sep 17, 2020

@pieceofsummer we are using this in production with a forked build of this project, do you see any issues with this PR, or could we get this merged into upstream? It is a major performance improvement, we had a job that was iterating over a collection with millions of entries so it went from millions of db writes in the extension method to a hundred or fewer, no matter the collection size..

@pieceofsummer
Copy link
Owner

I think there's a more elegant solution, by providing a configurable precision value used for rounding here:

So you don't need to track it manually elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants