Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for HTML logging. #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

plaisted
Copy link

Potential fix for issue #14.

Allows the use of context.WriteHtmlLine(string message) in order to write raw (unencoded) HTML to the dashboard for use of links etc.

Sample image below using WriteHtmlLine to insert a link to elasticsearch query through Kibana to display all the structured log messaged from this Hangfire job.

image

@pieceofsummer
Copy link
Owner

I don't like the idea of writing an unencoded html, because it can accidentally break the layout

@datumgeek
Copy link

what if properties for label and src were created instead and it would always generate a structured 'a' tag?

@plaisted
Copy link
Author

plaisted commented Jan 31, 2017

What about something similar to:

context.WriteLinks("Here is a {0} and another {1}", new HtmlLink { Text = "link", Url = "http://url" }, new HtmlLink { Text = "link here.", Url = "http://url2" });

Still allows you to format how to display the links but won't allow user to put unencoded HTML directly into dashboard.

@datumgeek
Copy link

@plaisted - the url recognizer is really cool - you can't format the display, but it works great for linking to related data and to other related jobs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants