Provider: Gcore #16
Merged
Provider: Gcore #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcore provider was requested in #12 and the work to do it was pretty straight forward. I took inspiration from gcore's external-dns provider(1) and while I did some tests, I'm not that familiar with the gcore so there might be more to it (like features that could be added, etc.) 1. https://github.com/G-Core/external-dns-gcore-webhook/blob/master/gcoreprovider/gcore.go
ainsey11
reviewed
Oct 23, 2024
ainsey11
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the PR to add support for GCore. I added a few things around like cleanup that should have been in a different PR, but I realized it just now.
This should close #12