Its not nescessary to define constexpr members in the cpp file with

c++17
piggz · Dec 28, 2023 · 1988a6a · 1988a6a
1 parent 5608feb
commit 1988a6a
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 41 deletions.
diff --git a/daemon/src/services/batteryservice.cpp b/daemon/src/services/batteryservice.cpp
@@ -3,7 +3,6 @@
 const char* BatteryService::UUID_SERVICE_BATTERY  = "0000180f-0000-1000-8000-00805f9b34fb";
 const char* BatteryService::UUID_CHARACTERISTIC_BATTERY_LEVEL = "00002a19-0000-1000-8000-00805f9b34fb";
 
-
 BatteryService::BatteryService(const QString &path, QObject *parent) : QBLEService(UUID_SERVICE_BATTERY, path, parent)
 {
     qDebug() << Q_FUNC_INFO;

diff --git a/daemon/src/services/bipfirmwareservice.cpp b/daemon/src/services/bipfirmwareservice.cpp
@@ -4,7 +4,6 @@ const char* BipFirmwareService::UUID_SERVICE_FIRMWARE = "00001530-0000-3512-2118
 const char* BipFirmwareService::UUID_CHARACTERISTIC_FIRMWARE = "00001531-0000-3512-2118-0009af100700";
 const char* BipFirmwareService::UUID_CHARACTERISTIC_FIRMWARE_DATA = "00001532-0000-3512-2118-0009af100700";
 
-
 BipFirmwareService::BipFirmwareService(const QString &path, QObject *parent) : QBLEService(UUID_SERVICE_FIRMWARE, path, parent)
 {
     qDebug() << "BipFirmwareService::BipFirmwareService";

diff --git a/daemon/src/services/deviceinfoservice.cpp b/daemon/src/services/deviceinfoservice.cpp
@@ -11,7 +11,6 @@ const char* DeviceInfoService::UUID_CHARACTERISTIC_INFO_MANUFACTURER_NAME = "000
 const char* DeviceInfoService::UUID_CHARACTERISTIC_INFO_SYSTEM_ID = "00002a23-0000-1000-8000-00805f9b34fb";
 const char* DeviceInfoService::UUID_CHARACTERISTIC_INFO_PNP_ID = "00002a50-0000-1000-8000-00805f9b34fb";
 
-
 DeviceInfoService::DeviceInfoService(const QString &path, QObject *parent) : QBLEService(UUID_SERVICE_DEVICEINFO, path, parent)
 {
     qDebug() << "BipInfoService::BipInfoService";

diff --git a/daemon/src/services/dfuservice.cpp b/daemon/src/services/dfuservice.cpp
@@ -6,15 +6,6 @@ const char* DfuService::UUID_CHARACTERISTIC_DFU_CONTROL = "00001531-1212-efde-15
 const char* DfuService::UUID_CHARACTERISTIC_DFU_PACKET = "00001532-1212-efde-1523-785feabcd123";
 const char* DfuService::UUID_CHARACTERISTIC_DFU_REVISION = "00001534-1212-efde-1523-785feabcd123";
 
-constexpr uint8_t DfuService::COMMAND_STARTDFU;
-constexpr uint8_t DfuService::COMMAND_RESPONSE;
-constexpr uint8_t DfuService::COMMAND_INITDFUPARAMETERS;
-constexpr uint8_t DfuService::COMMAND_VALIDATE_FIRMWARE;
-constexpr uint8_t DfuService::COMMAND_RECEIVE_FIRMWARE_IMAGE;
-constexpr uint8_t DfuService::COMMAND_ACTIVATE_IMAGE_AND_RESET;
-constexpr uint8_t DfuService::COMMAND_PACKET_RECEIPT_NOTIFICATION;
-constexpr uint8_t DfuService::COMMAND_PACKET_RECEIPT_NOTIFICATION_REQUEST;
-
 DfuService::DfuService(const QString &path, QObject *parent) : QBLEService(UUID_SERVICE_DFU, path, parent)
 {
     qDebug() << Q_FUNC_INFO;

diff --git a/daemon/src/services/mibandservice.cpp b/daemon/src/services/mibandservice.cpp
@@ -22,35 +22,6 @@ const char* MiBandService::UUID_CHARACTERISTIC_MIBAND_CHUNKED_TRANSFER = "000000
 const char* MiBandService::UUID_CHARACTERISTIC_MIBAND_2021_CHUNKED_CHAR_WRITE = "00000016-0000-3512-2118-0009af100700";
 const char* MiBandService::UUID_CHARACTERISTIC_MIBAND_2021_CHUNKED_CHAR_READ = "00000017-0000-3512-2118-0009af100700";
 
-constexpr uint8_t MiBandService::DATEFORMAT_TIME[];
-constexpr uint8_t MiBandService::DATEFORMAT_DATETIME[];
-constexpr uint8_t MiBandService::DATEFORMAT_TIME_12_HOURS[];
-constexpr uint8_t MiBandService::DATEFORMAT_TIME_24_HOURS[];
-constexpr uint8_t MiBandService::COMMAND_ENABLE_DISPLAY_ON_LIFT_WRIST[];
-constexpr uint8_t MiBandService::COMMAND_DISABLE_DISPLAY_ON_LIFT_WRIST[];
-constexpr uint8_t MiBandService::COMMAND_SCHEDULE_DISPLAY_ON_LIFT_WRIST[];
-constexpr uint8_t MiBandService::COMMAND_ENABLE_GOAL_NOTIFICATION[];
-constexpr uint8_t MiBandService::COMMAND_DISABLE_GOAL_NOTIFICATION[];
-constexpr uint8_t MiBandService::COMMAND_ENABLE_ROTATE_WRIST_TO_SWITCH_INFO[];
-constexpr uint8_t MiBandService::COMMAND_DISABLE_ROTATE_WRIST_TO_SWITCH_INFO[];
-constexpr uint8_t MiBandService::COMMAND_ENABLE_DISPLAY_CALLER[];
-constexpr uint8_t MiBandService::COMMAND_DISABLE_DISPLAY_CALLER[];
-constexpr uint8_t MiBandService::COMMAND_DISTANCE_UNIT_METRIC[];
-constexpr uint8_t MiBandService::COMMAND_DISTANCE_UNIT_IMPERIAL[];
-constexpr uint8_t MiBandService::COMMAND_SET_FITNESS_GOAL_START[];
-constexpr uint8_t MiBandService::COMMAND_SET_FITNESS_GOAL_END[];
-constexpr uint8_t MiBandService::COMMAND_CHANGE_SCREENS[];
-constexpr uint8_t MiBandService::COMMAND_ENABLE_DISCONNECT_NOTIFICATION[];
-constexpr uint8_t MiBandService::COMMAND_DISABLE_DISCONNECT_NOTIFICATION[];
-
-constexpr uint8_t MiBandService::DISPLAY_XXX[];
-constexpr uint8_t MiBandService::DISPLAY_YYY[];
-constexpr uint8_t MiBandService::WEAR_LOCATION_LEFT_WRIST[];
-constexpr uint8_t MiBandService::WEAR_LOCATION_RIGHT_WRIST[];
-constexpr uint8_t MiBandService::RESPONSE_ACTIVITY_DATA_START_DATE_SUCCESS[];
-constexpr uint8_t MiBandService::RESPONSE_FINISH_SUCCESS[];
-constexpr uint8_t MiBandService::RESPONSE_FINISH_FAIL[];
-
 MiBandService::MiBandService(const QString &path, QObject *parent) : QBLEService(UUID_SERVICE_MIBAND, path, parent)
 {
     qDebug() << "MiBandService::MiBandService";