-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable realtime HRM from Device Settings Page #306
Conversation
Enable realtimeMeasurement tells the watch to enable its on-board periodic measurement (must be supported) ... enableManualMeasurement tells the watch to "take a measurement now please" For the pinetime, i think the only current options is periodic manual measurement, as there is no feature for having the watch log measurements automatically. |
Yes, the issue is, that without If I understand correctly the right method is |
This should allow realtime HRM measurement (i.e. notifications in BT profile). Dark side is that it is necessary to allow it in Settings. The user can be confused that data aren't actually there. On the other hand user can be surprised that it drains device battery (haven't measured that actually) and doesn't bring much changes (mostly for huami device). Although I see the pull request as an improvement. |
ui/qml/pages/Settings-device.qml
Outdated
@@ -121,6 +130,7 @@ PagePL { | |||
DaemonInterfaceInstance.applyDeviceSetting(Amazfish.SETTING_DEVICE_TIME); | |||
DaemonInterfaceInstance.applyDeviceSetting(Amazfish.SETTING_DEVICE_UNIT); | |||
DaemonInterfaceInstance.applyDeviceSetting(Amazfish.SETTING_DISCONNECT_NOTIFICATION); | |||
DaemonInterfaceInstance.applyDeviceSetting(SETTING_DEVICE_REALTIME_HRM_MEASUREMENT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntax here is different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Right now I am not sure how to do this properly.
With #303 the sampled data are stored the realtime data are stored into database, but the notification of heart rate monitor must be enabled explicitly
harbour-amazfish/daemon/src/deviceinterface.cpp
Line 741 in dc0aa13
There is enableRealtimeHRMeasurement and enableManualHRMeasurement
harbour-amazfish/daemon/src/services/hrmservice.cpp
Line 37 in dc0aa13
both methods subscribes for messages. They are sending also some sending messages upon to infinitime.
It can be probably some option in settings, which automatically subscribes to HRM upon connecting to device. In combination with lousy connection stability it doesn't measure very few data without that.