Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmazfitNeo notification is using AlertNotificationService #357

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Apr 5, 2024

it seems that max length of message is limited.
The specification says 18 characters. The screen shows only "+1" or "+2" anyway.

Code worked for me, but it would be great if @kirbylife can look at it as well.

it seems that max lenght of message is limited. The specification says
18 characters. The screen shows only "+1" or "+2" anyway.
@kirbylife
Copy link

Yes, it seems to work as it would on Android.
The only issue I see is that there is no way to enable/disable that feature from Amazfish, I had to go to GadgetBridge to enable notifications and then go back to Amazfish to test.
I don't know if I didn't find the way to do it or if it is expected.

@jmlich
Copy link
Contributor Author

jmlich commented Apr 12, 2024

I don't think that there is such configuration in Amazfish. However, it can added.

@kirbylife
Copy link

I liked the way you implemented it.
Adding the option to enable/disable notifications could go in another PR.

@piggz piggz merged commit 26a3722 into piggz:master Apr 28, 2024
3 checks passed
@jmlich jmlich deleted the amazfit-neo-notifications branch April 28, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants