[kirigami] DatePicker dialog doesn't pop() when accepted

[jmlich]

In c48f79b there was a fix of Dialog behaviour for Device Unpair operation. This broke DatePicker Dialog (User Settings -> Birthday) .

In this fix is used acceptDestination variable show the Unpair works with previous implementation and DatePicker works as well.

Same issue applies to TimePicker Dialog as well.

The change may affect also unpair page

[piggz]

is this still wip?

[jmlich]

Yes, there are at least two cases with use of that mechanism which are bound together. I not sure exactly, therefore mentioning following three (maybe I have missed something):

• SettingsProfile -> Birthday (DatePickerDialogPL) -> Save()
• FirstPage -> PairSelectDeviceType -> PairPage -> FirstPage

# to avoid UnPairDialog is necessary to remove old settings manually.
[defaultuser@PinePhone ~]$ dconf list /uk/co/piggz/amazfish/
[defaultuser@PinePhone ~]$ dconf reset /uk/co/piggz/amazfish/pairedName
[defaultuser@PinePhone ~]$ dconf reset /uk/co/piggz/amazfish/pairedAddress
rm -f ~/.config/harbour-amazfish/harbour-amazfish.conf

• FirstPage -> UnpairDeviceDialog -> PairSelectDeviceType -> PairPage -> FirstPage (UnpairDeviceDialog must not appear)

I have seen some suspicious behavior with UnPairDialog, where it should replace dialog or pass it with attachedpage mechanism, but it was somehow unreliable. I have seen overlapped FirstPage in background in SailfishOS.

I have spent some time with that already without reasonable result.

[jmlich]

Works on SailfishOS and Kirigami, but on Ubuntu Touch is following error when clicked to unpair:

Nov 22 15:22:46 ubuntu-phablet aa-exec[3723]: file:///opt/click.ubuntu.com/uk.co.piggz.amazfish/2.4.0/share/harbour-amazfish-ui/qml/components/platform/DialogPL.qml:44: TypeError: Property 'push' of object ApplicationWindowPL_QMLTYPE_3_QML_42(0x62970b2840) is not a function

[jmlich]

It looks like everything works now on all platforms. I am wondering if there were another scenario which I didn't considered or forgot.