SailfishOS: enable cover page #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the SailfishOS cover page was disabled some time ago. It seems it have useful information to show and allows more user interaction.
The property was added in order to allow use it with other flavors.
It was necessary to fix images path. The
styler.iconHeartratecontain one more level so I have decided to use absolute path for now.I have verified Amazfish with this change works on SailfishOS, Ubuntu Touch and Kirigami platform.
The other way is to move ui/qml/cover/CoverPage.qml to /ui/qml/components/platform.silica/Cover.qml, but it would make components/ application specific, which is probably unwanted.