pair function shoud invoke QBLEDevice::pair() #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discovered that
QBLEDevice::connectToDevice();is used instead ofQBLEDevice::pair();in InfiniTime. It seems to be legacy code intended to fix connection issues with older PineTime firmware.The same code was copied and pasted into AsteroidOS.
I have tested this behavior with PineTime and AsteroidOS on Ubuntu Touch (Volla1), SailfishOS (PinePhone), and Kirigami (my desktop setup), and it works in my opinion much better than before.
I have noticed the same thing in Bangle.js code. I assume it will work better as well, but I currently don't have a device to test. Occasionally, I can borrow a device for testing, but it might take some time.
I have also observed that on Ubuntu Touch, the "system-wide" Authentication Agent seems to appear only when the Bluetooth Settings dialog is open. I suspect this is an issue with Ubuntu Touch. Previously, the dialog did not appear during pairing at all. - This was reported here https://gitlab.com/ubports/development/core/lomiri-system-settings/-/issues/379
Note: It might be necessary to remove device or forget device in system setting first.