Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate ray and firefish device names in PairSelectDeviceType.qml #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eLtMosen
Copy link

Attempt to address an issue where the ray and firefish devices do not appear in the pairing UI of Amazfish. It appears that ray and firefish were grouped together in PairSelectDeviceType.qml, whereas they are handled separately in devicefactory.cpp.

This change separates the two devices in the UI, aligning with the handling observed in devicefactory.cpp. While untested, this adjustment aims to resolve the potential mismatch and allow proper pairing for ray and firefish.

Attempt to address an issue where the ray and firefish devices do not appear in the pairing UI of Amazfish. It appears that ray and firefish were grouped together in PairSelectDeviceType.qml, whereas they are handled separately in devicefactory.cpp.

This change separates the two devices in the UI, aligning with the handling observed in devicefactory.cpp. While untested, this adjustment aims to resolve the potential mismatch and allow proper pairing for ray and firefish.
jmlich added a commit to jmlich/harbour-amazfish that referenced this pull request Jan 25, 2025
@jmlich
Copy link
Contributor

jmlich commented Jan 25, 2025

Great that you test all AsteroidOS devices.
I have updated the PairSelectDeviceType recently in #458. I have included your fix also into my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants