Do not store CORS headers in output cache #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
This does not fix the issue entirely. I am experiencing responses with missing Access-Control-Allow-Origin. Going to look into it. |
gajdusek
force-pushed
the
fix/output-cache-cors
branch
from
c130c8c to
606d7c8
Compare
Ensure that that dynamic Access-Control-Allow-Origin header is not cached. - Remove Access-Control-Allow-Origin header before saving to cache - Add Access-Control-Allow-Origin dynamically when serving cached responses based on the incoming request's Origin This resolves issues with CORS headers being cached alongside GraphQL responses, which could cause incorrect Access-Control-Allow-Origin values for clients with different origins.
gajdusek
force-pushed
the
fix/output-cache-cors
branch
from
606d7c8 to
7fb17e2
Compare
|
It's fixed. |
|
I have read the CLA Document and I hereby sign the CLA |
gajdusek
changed the title
gajdusek
changed the title
|
LGTM, thank you! |
|
Cherry picked to 1.8 -> b71636a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that that dynamic Access-Control-Allow-Origin header is not cached.
This resolves issue (#895) with CORS headers being cached alongside GraphQL responses, which could cause incorrect Access-Control-Allow-Origin values for clients with different origins.