-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow any type of processor classes #50
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@kingjia90 I see that a new release has been created without this PR. Are there any changes to be made? |
@Cruiser13 Unfortunately this is PR was not being reviewed yet and not in the main pipeline. The changes looks fine so far, at least as quick fix, but maybe lacks a way to provide the settings by GUI eg. web-to-print-bundle/public/js/settings.js Lines 342 to 353 in 70b7474
|
Thanks for letting me know. Since we can not know which settings the custom processor has I don't see a good way to add them here. And you can override the JS in your custom processor anyway. We re-implemented the wkhtmltopdf processor with these changes and simply supplied the web2print options in the class. Works fine. |
@kingjia90 what do you think? |
Allows any processor classes as discussed in #44
Tagged services and a service locator would be the better way but overpowered for this use case I think. Let me know your thoughts.
Thank you for considering the PR.