Use constant-time base64 implementation #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the outdated base64 depenency. Instead of updating to the latest version, this switches to ct_codecs, which is better suited for working with cryptographic keys. Using ct_codecs instead of alternatives like base64ct, because ct_codecs is already a dependency via jwt-simple. This also removes the reexported base64 configuration options from the API. Web Push uses URL-safe encoding without padding everywhere. If needed for custom purposes, users can encode/decode on their end, without having to use types from the exact base64 crate used in this library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the outdated base64 depenency. Instead of updating to the latest version, this switches to ct_codecs, which is better suited for working with cryptographic keys. Using ct_codecs instead of alternatives like base64ct, because ct_codecs is already a dependency via jwt-simple.
This also removes the reexported base64 configuration options from the API. Web Push uses URL-safe encoding without padding everywhere. If needed for custom purposes, users can encode/decode on their end, without having to use types from the exact base64 crate used in this library.