Had to do this to get it to work (#55) #47
clippy
6 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 6 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.78.0-nightly (c475e2303 2024-02-28)
- cargo 1.78.0-nightly (8964c8ccf 2024-02-27)
- clippy 0.1.78 (c475e23 2024-02-28)
Annotations
Check warning on line 211 in src/message.rs
github-actions / clippy
manual `RangeInclusive::contains` implementation
warning: manual `RangeInclusive::contains` implementation
--> src/message.rs:211:64
|
211 | return (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c == '-' || c == '_');
| ^^^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
Check warning on line 211 in src/message.rs
github-actions / clippy
manual `RangeInclusive::contains` implementation
warning: manual `RangeInclusive::contains` implementation
--> src/message.rs:211:38
|
211 | return (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c == '-' || c == '_');
| ^^^^^^^^^^^^^^^^^^^^^^ help: use: `('a'..='z').contains(&c)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
Check warning on line 211 in src/message.rs
github-actions / clippy
manual `RangeInclusive::contains` implementation
warning: manual `RangeInclusive::contains` implementation
--> src/message.rs:211:12
|
211 | return (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c == '-' || c == '_');
| ^^^^^^^^^^^^^^^^^^^^^^ help: use: `('A'..='Z').contains(&c)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
= note: `#[warn(clippy::manual_range_contains)]` on by default
Check warning on line 211 in src/message.rs
github-actions / clippy
unneeded `return` statement
warning: unneeded `return` statement
--> src/message.rs:211:5
|
211 | return (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c == '-' || c == '_');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
211 - return (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c == '-' || c == '_');
211 + (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || (c >= '0' && c <= '9') || (c == '-' || c == '_')
|
Check warning on line 5 in src/vapid/mod.rs
github-actions / clippy
unused import: `self::signer::Claims`
warning: unused import: `self::signer::Claims`
--> src/vapid/mod.rs:5:9
|
5 | pub use self::signer::Claims;
| ^^^^^^^^^^^^^^^^^^^^
Check warning on line 3 in src/error.rs
github-actions / clippy
the item `From` is imported redundantly
warning: the item `From` is imported redundantly
--> src/error.rs:3:11
|
3 | use std::{convert::From, error::Error, fmt, io::Error as IoError};
| ^^^^^^^^^^^^^
--> /rustc/c475e2303b551d726307c646181e0677af1e0069/library/std/src/prelude/mod.rs:129:13
|
= note: the item `From` is already defined here
|
= note: `#[warn(unused_imports)]` on by default