always fetch gasPrice from network when bundling (#347)

Co-authored-by: mouseless <[email protected]>
pimlicolabs · Oct 30, 2024 · ac6c685 · ac6c685
1 parent 7b15e26
commit ac6c685
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/src/executor/executor.ts b/src/executor/executor.ts
@@ -148,7 +148,8 @@ export class Executor {
     ): Promise<ReplaceTransactionResult> {
         const newRequest = { ...transactionInfo.transactionRequest }
 
-        const gasPriceParameters = await this.gasPriceManager.getGasPrice()
+        const gasPriceParameters =
+            await this.gasPriceManager.getNetworkGasPrice()
 
         newRequest.maxFeePerGas = maxBigInt(
             gasPriceParameters.maxFeePerGas,
@@ -490,7 +491,7 @@ export class Executor {
 
         const wallets = Array.from(allWallets)
 
-        const gasPrice = await this.gasPriceManager.getGasPrice()
+        const gasPrice = await this.gasPriceManager.getNetworkGasPrice()
         const promises = wallets.map((wallet) => {
             flushStuckTransaction(
                 this.config.publicClient,
@@ -666,7 +667,8 @@ export class Executor {
         })
         childLogger.debug("bundling user operation")
 
-        const gasPriceParameters = await this.gasPriceManager.getGasPrice()
+        const gasPriceParameters =
+            await this.gasPriceManager.getNetworkGasPrice()
         childLogger.debug({ gasPriceParameters }, "got gas price")
 
         const nonce = await this.config.publicClient.getTransactionCount({
@@ -945,7 +947,8 @@ export class Executor {
         })
         childLogger.debug("bundling compressed user operation")
 
-        const gasPriceParameters = await this.gasPriceManager.getGasPrice()
+        const gasPriceParameters =
+            await this.gasPriceManager.getNetworkGasPrice()
         childLogger.debug({ gasPriceParameters }, "got gas price")
 
         const nonce = await this.config.publicClient.getTransactionCount({

diff --git a/src/executor/executorManager.ts b/src/executor/executorManager.ts
@@ -775,7 +775,8 @@ export class ExecutorManager {
         await this.refreshUserOperationStatuses()
 
         // for all still not included check if needs to be replaced (based on gas price)
-        const gasPriceParameters = await this.gasPriceManager.getGasPrice()
+        const gasPriceParameters =
+            await this.gasPriceManager.getNetworkGasPrice()
         this.logger.trace(
             { gasPriceParameters },
             "fetched gas price parameters"

diff --git a/src/executor/senderManager.ts b/src/executor/senderManager.ts
@@ -138,7 +138,7 @@ export class SenderManager {
 
         if (Object.keys(balancesMissing).length > 0) {
             const { maxFeePerGas, maxPriorityFeePerGas } =
-                await this.gasPriceManager.getGasPrice()
+                await this.gasPriceManager.getNetworkGasPrice()
 
             if (this.config.refillHelperContract) {
                 const instructions = []

diff --git a/src/handlers/gasPriceManager.ts b/src/handlers/gasPriceManager.ts
@@ -417,6 +417,10 @@ export class GasPriceManager {
         }
     }
 
+    public async getNetworkGasPrice(): Promise<GasPriceParameters> {
+        return await this.innerGetGasPrice()
+    }
+
     public async getMaxBaseFeePerGas(): Promise<bigint> {
         let maxBaseFeePerGas = this.baseFeePerGasQueue.getMaxValue()
         if (!maxBaseFeePerGas) {