Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #1292

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[pre-commit.ci] pre-commit autoupdate #1292

merged 1 commit into from
Nov 15, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 22, 2023 •
edited
Loading

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 51d10ed to df7e4c6 Compare August 29, 2023 06:24
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from df7e4c6 to 3523670 Compare September 5, 2023 07:38
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 47520ff to 868e839 Compare September 19, 2023 07:55
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3f5633e to 4afc94c Compare September 26, 2023 08:12
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 01610ed to 1f5ebe8 Compare October 9, 2023 20:46
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 56f5148 to 2f97023 Compare October 16, 2023 20:14
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from afe3af0 to e749162 Compare October 23, 2023 20:40
@geier geier force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 471c9ed to 6f40d54 Compare October 30, 2023 10:48
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 7587dff to bea920f Compare November 6, 2023 20:18
@WhyNotHugo
Copy link
Member

(I tend to only merge these when they actually include fixes. Otherwise weekly updates add too much noise to git history)

@geier
Copy link
Member

geier commented Nov 7, 2023

@WhyNotHugo agreed, but this one found at least the type() issues. Not so sure about the issue in setup.py. The options I see are removing the if sys.version() part completely or adding a # noqa behind.

@WhyNotHugo
Copy link
Member

A # noqa: UP036 sounds good. This check honestly bothers me a bit; this code is perfectly valid, even if this version of Python is unsupported.

Switching to pyproject.toml entirely would negate the issue completely.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from d917f21 to 01a7ef8 Compare November 13, 2023 20:48
This was referenced Nov 14, 2023
Closed
Merged
@pre-commit-ci @geier
[pre-commit.ci] pre-commit autoupdate
e2fb590 
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/pre-commit/mirrors-mypy: v1.5.0 → v1.7.0](pre-commit/mirrors-mypy@v1.5.0...v1.7.0)
- [github.com/astral-sh/ruff-pre-commit: v0.0.284 → v0.1.5](astral-sh/ruff-pre-commit@v0.0.284...v0.1.5)
@geier geier force-pushed the pre-commit-ci-update-config branch from 01a7ef8 to e2fb590 Compare November 15, 2023 19:58
@geier geier merged commit ffef884 into master Nov 15, 2023
4 checks passed
@geier geier deleted the pre-commit-ci-update-config branch November 15, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhyNotHugo WhyNotHugo WhyNotHugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhyNotHugo @geier