This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
support list canopy indexes #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igiloh-pinecone
approved these changes
Oct 29, 2023
Comment on lines
53
to
58
| try: | ||
| pinecone_init() | ||
| pinecone_whoami() | ||
| except Exception as e: | ||
| raise RuntimeError("Failed to connect to Pinecone. " | ||
| "Please check your credentials and try again") from e |
There was a problem hiding this comment.
Suggested change
| try: | |
| pinecone_init() | |
| pinecone_whoami() | |
| except Exception as e: | |
| raise RuntimeError("Failed to connect to Pinecone. " | |
| "Please check your credentials and try again") from e | |
| KnowledgeBase._connect_pinecone() |
There was a problem hiding this comment.
I extracted the functionality to module level since this method should not know about kB
There was a problem hiding this comment.
Still - no need for code duplication. They are in the same module (no imports required), and _connect_pinecone is a static function (you don't need to instantiate a KB instance).
It's perfectly ok to call it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Canopy does not provide any way to list Canopy's indexes in Pinecone
Solution
Add a module level method to list Canopy indexes
Type of Change
Test Plan
Added a system test