Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

change defaults #124

Merged
merged 1 commit into from
Oct 30, 2023
Merged

change defaults #124

merged 1 commit into from
Oct 30, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 30, 2023

Problem

Current defaults for OpenAI embeddings and Pinecone batch upsert are sub-optimal

Solution

Increase defaults to meet free tier limitations of OpenAI and Pinecone

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Same tests apply. I run it manually with some arxiv data

@acatav acatav marked this pull request as ready for review October 30, 2023 11:54
igiloh-pinecone
igiloh-pinecone approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acatav acatav added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@acatav acatav added this pull request to the merge queue Oct 30, 2023
Merged via the queue into dev with commit aa7424a Oct 30, 2023
10 checks passed
@acatav acatav deleted the increase-upsert-defaults branch October 30, 2023 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatav @igiloh-pinecone