Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Tokenizer docstrings #131

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Tokenizer docstrings #131

merged 8 commits into from
Nov 2, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Nov 1, 2023

Problem

There are no docstrings for the tokenizers

Solution

Add docstrings

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Only a documantion change

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good, see a few comments

src/canopy/tokenizer/tokenizer.py Outdated Show resolved Hide resolved
src/canopy/tokenizer/tokenizer.py Outdated Show resolved Hide resolved
src/canopy/tokenizer/tokenizer.py Outdated Show resolved Hide resolved
src/canopy/tokenizer/tokenizer.py Outdated Show resolved Hide resolved
@acatav acatav enabled auto-merge November 2, 2023 10:32
@acatav acatav added this pull request to the merge queue Nov 2, 2023
Merged via the queue into dev with commit 243ffec Nov 2, 2023
10 checks passed
@acatav acatav deleted the tokenizer-docstrings branch November 2, 2023 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants