-
Notifications
You must be signed in to change notification settings - Fork 122
feat: Qdrant as a supported knowledge base #244
Conversation
a8befc7
to
6f01e6b
Compare
Thank you @Anush008 for the great contribution!! |
Thanks @igiloh-pinecone. |
Any news on that a month later? :) |
Hi @ChristopherDosin, |
Awesome, thank you my friend - Just wondering which one performs better :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Anush008 thank you very much for your contribution!!
Apologies for the delayed review.
Please see a few comments. Namely, please try to re-use as much test_
code as possible instead of duplicating it. This will make future changes to KnowledgeBase
much more maintainable.
tests/system/knowledge_base/qdrant/test_qdrant_knowledge_base.py
Outdated
Show resolved
Hide resolved
tests/system/knowledge_base/qdrant/test_qdrant_knowledge_base.py
Outdated
Show resolved
Hide resolved
e027521
to
2895775
Compare
3f34b7a
to
d9f80e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @Anush008 for this effort
Looking forward to having this land. Anything holding this up? |
As far as I recall some system test failed in the merge queue 🤔 . |
@igiloh-pinecone, I've updated the branch. Could you try now please? |
c7b3491
to
6a35ae5
Compare
The flaky CI failures seem to arise from unrelated files. UPDATE: This should be resolved with #327. |
Nice. When is the next release likely to get cut? |
We have a new release: https://github.com/pinecone-io/canopy/releases/tag/v0.9.0 |
Description
This PR adds support for Qdrant to be used as a knowledge base.
Type of Change
Test Plan
Tests have been added to
tests/system/qdrant
for the sync and async implementations and are configured to run using both, an in-memory Qdrant instance and Qdrant server(if running at port 6333, skipped otherwise).Note
The
qdrant_client
dependency can be gated behind an extra if needed and CLI support can be added subsequently.