Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Fix docker build #282

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Fix docker build #282

merged 1 commit into from
Feb 8, 2024

Conversation

izellevy
Copy link
Collaborator

@izellevy izellevy commented Feb 8, 2024 •
edited
Loading

Problem

Docker build does not take the arguments correctly.

Solution

Wrap the string with quotes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@izellevy izellevy requested a review from acatav February 8, 2024 16:22
acatav
acatav approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@acatav acatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@izellevy izellevy added this pull request to the merge queue Feb 8, 2024
Merged via the queue into pinecone-io:main with commit 9110193 Feb 8, 2024
7 checks passed
@izellevy izellevy deleted the bug/docker-build-string branch February 8, 2024 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acatav acatav acatav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izellevy @acatav