This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
update gunicorn #354
Closed
update gunicorn #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
izellevy
reviewed
Nov 4, 2024
| @@ -79,6 +79,7 @@ types-requests = "^2.31.0.2" | |||
| httpx = "^0.25.0" | |||
| pydoclint = "^0.3.8" | |||
| pytest-dotenv = "^0.5.2" | |||
| nltk = "3.8.1" | |||
There was a problem hiding this comment.
What is the reasoning behind adding nltk as a dependency?
There was a problem hiding this comment.
yeah this sovled the CI failing problem of loading some NLTK libs
see here: Unstructured-IO/unstructured#3511
izellevy
approved these changes
Nov 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
gunicorn dep is ood
Solution
fixing gunicorn dep, using poetry instead of dependabot
closes #353
closes #350
Type of Change
Test Plan
Describe specific steps for validating this change.