Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Connect to index in KB init #38

Merged
merged 21 commits into from
Sep 11, 2023
Merged

Connect to index in KB init #38

merged 21 commits into from
Sep 11, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Sep 7, 2023

Connecting to the index in KB init instead of using additional connect call

@acatav acatav changed the base branch from main to dev September 7, 2023 10:58
igiloh-pinecone
igiloh-pinecone suggested changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things need to change, namely the constructor should be a classmethod and we should merge the system tests branch into this branch before merging

context_engine/knoweldge_base/knowledge_base.py Show resolved Hide resolved
context_engine/knoweldge_base/knowledge_base.py Outdated Show resolved Hide resolved
context_engine/knoweldge_base/knowledge_base.py Outdated Show resolved Hide resolved
context_engine/knoweldge_base/knowledge_base.py Outdated Show resolved Hide resolved
context_engine/knoweldge_base/knowledge_base.py Outdated Show resolved Hide resolved
context_engine/knoweldge_base/knowledge_base.py Outdated Show resolved Hide resolved
tests/system/knowledge_base/test_knowledge_base.py Outdated Show resolved Hide resolved
@acatav acatav changed the base branch from dev to ci_system_tests September 10, 2023 19:06
Base automatically changed from ci_system_tests to dev September 10, 2023 19:42
igiloh-pinecone
igiloh-pinecone approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@igiloh-pinecone igiloh-pinecone merged commit a9badaa into dev Sep 11, 2023
@igiloh-pinecone igiloh-pinecone deleted the create-index-kb-init branch September 11, 2023 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatav @igiloh-pinecone