This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 122
Adapted app.py to work with latest code #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can run tests in parallel == faster
I set all the KB tests to run in one pytest-xdist process, so they will run one after the other - since they are all using the same index
- Object initialization - OpenAI API returns event stream, not byte stream - A few minor fixes
These defaults are what we expect real users to use
Less effort for the user
igiloh-pinecone
force-pushed
the
server
branch
from
September 10, 2023 11:58
579e96b
to
4f174d6
Compare
igiloh-pinecone
force-pushed
the
ci_system_tests
branch
from
September 10, 2023 12:32
5a278fb
to
f8854a3
Compare
This way the code is slightly safer
The service is not part of the library in any way
Will mostly be used later for feedback
Just to be more consistent
In the case of `stream=True`, we returned a generator of chunks, so there was no place to put the debug_info
Can be used for feedback
Need to improve
Now it prints both to stdout and file
Team decided this is a better name
Very basic for now, but it will do
igiloh-pinecone
changed the title
WIP: Adapted app.py to work with latest code
Adapted app.py to work with latest code
Sep 11, 2023
acatav
approved these changes
Sep 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app.py now works, exposing OpenAI-like API