Skip to content
This repository was archived by the owner on Nov 13, 2024. It is now read-only.

Remove langchain dependency #41

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Sep 10, 2023

Problem

Langhain is unstable dependency, even with the vanilla installation

Solution

Take only the parts we need for chunking (with appropriate credit)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Adjust unit tests

@acatav acatav changed the base branch from main to dev September 10, 2023 12:55
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is copy-pasted, I'm not even going to review this file...

@igiloh-pinecone igiloh-pinecone merged commit 52fd4ee into dev Sep 11, 2023
@igiloh-pinecone igiloh-pinecone deleted the remove-langchain-dependency branch September 11, 2023 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants