This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
E2e test fixes #54
Merged
E2e test fixes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use a context manager on `TestClient` (call it in a `with()` cluase) to properly start the app inside
Used fixtures to correctly set the a random index name, and a fixture for tearing it down even if there was a failure
The retry needs to retry the /query operation itself.
Tested, this solution works
miararoy
approved these changes
Oct 1, 2023
| def test_upsert(client): | ||
| # Upsert a document to the index | ||
| upsert_response = client.post("/context/upsert", json=upsert_payload.dict()) | ||
| assert upsert_response.is_success |
There was a problem hiding this comment.
if you're separating the test so each one should have at least 1 logical test and not just operational (is_success)
There was a problem hiding this comment.
How? There's no return value for upsert...
| chat_response_content = chat_response_as_json["choices"][0]["message"][ | ||
| "content" | ||
| ] | ||
| print(chat_response_content) |
There was a problem hiding this comment.
You're asking me...?
That's your code!
This way it will run from any working directory
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multiple problems:
startupevent)test_function instead of separate test case per app routeSolution
Use proper
fixtures and context manager.Type of Change