Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

Remove unused dependencies #82

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Remove unused dependencies #82

merged 2 commits into from
Oct 22, 2023

Conversation

acatav
Copy link
Contributor

@acatav acatav commented Oct 19, 2023

Remove unused dependencies from poetry toml file

@@ -17,9 +17,7 @@ tiktoken = "^0.3.3"
pinecone-datasets = "^0.6.1"
pydantic = "^1.10.7"
pinecone-text = { version = "^0.6.0", extras = ["openai"] }
flake8-pyproject = "^1.2.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this one. Without it flake8 doesn't read its configuration in the pyproject.toml file.
You can move it to the dev section where it belongs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have it in the dev section, that's why I removed it from here. We don't need it in both right? (please verify me before approving)

Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acatav acatav merged commit 88ab664 into dev Oct 22, 2023
10 checks passed
@acatav acatav deleted the remove-langchain-dep branch October 22, 2023 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants