-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Problem [Index tags are a feature ](https://docs.pinecone.io/guides/indexes/tag-an-index) which was included in the `2024-10` API specification, but was not implemented in the SDK interface. ## Solution - Add new `IndexTags` type to `models.go`. This just represents `map[string]string`, lining up with the generated type. - Update `CreateServerlessIndexRequest`, `CreatePodIndexRequest`, and `ConfigureIndexParams` to allow passing `IndexTags` optionally. - Update integration test setup / teardown to support working with tags. Add a new test method to exercise validating tags, and updating them through `ConfigureIndex`. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan CI Integration Tests should pass - these create serverless & pod indexes with tags, and then a test checks the tags and updates them as a part of the integration test suite. To work with tags directly in Go: ```go indexTags := IndexTags{"test1": "test-tag-1", "test2": "test-tag-2"} serverlessIdx, err := in.CreateServerlessIndex(ctx, &CreateServerlessIndexRequest{ Name: "test-index", Dimension: uint32(5), Metric: Cosine, Region: "us-east-1", Cloud: "aws", Tags: &indexTags, }) ``` --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208820098587324
- Loading branch information
1 parent
1aa2cd5
commit d406377
Showing
6 changed files
with
74 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters