Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin oapi-codegen version to latest that uses the /deepmap path #26

Closed
wants to merge 2 commits into from

Conversation

aulorbe
Copy link
Contributor

@aulorbe aulorbe commented Jun 18, 2024

Problem

oapi-codegen recently changed its location. In order to keep code changes in our go repo as minimal as possible, we need to change our justfile so that it goes from grabbing the @latest release of oapi-codegen to grabbing the latest version that still uses the old path, which is version 2.2.0.

Solution

Pin version of oapi-codegen at 2.2.0.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

CI passes.


@aulorbe aulorbe requested a review from haruska June 18, 2024 21:31
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job tracking this one down. This makes sense to me, especially given the link you provided, thanks!

Maybe double check with @haruska as I'd asked him about this dep previously.

Copy link
Contributor

@haruska haruska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the changelog seems the diff from v2.2 and v2.3 is largely text changes along with the repo change.

Could we update to the new repo and v2.3 instead of pinning to the old repo?

Edit: Something like this: https://github.com/pinecone-io/go-pinecone/compare/pin_codegen_versions?expand=1

@aulorbe
Copy link
Contributor Author

aulorbe commented Jun 25, 2024

Looking at the changelog seems the diff from v2.2 and v2.3 is largely text changes along with the repo change.

Could we update to the new repo and v2.3 instead of pinning to the old repo?

Edit: Something like this: https://github.com/pinecone-io/go-pinecone/compare/pin_codegen_versions?expand=1

Nice! Closing this PR then in favor of the one you started :)

@aulorbe aulorbe closed this Jun 25, 2024
@aulorbe aulorbe deleted the Audrey/openapi-version-pin branch June 26, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants