Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Go documentation link #28

Closed
wants to merge 1 commit into from
Closed

update Go documentation link #28

wants to merge 1 commit into from

Conversation

junefish
Copy link
Contributor

Problem

Existing link was moved https://github.com/golang/go/wiki/Modules
Screenshot 2024-06-21 at 4 00 43 PM

Solution

Changed to current link

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

N/A

Copy link
Contributor

@aulorbe aulorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@aulorbe
Copy link
Contributor

aulorbe commented Jun 21, 2024

Great change! Let's wait until @austin-denoble gets back to merge, since CI is failing due to a missing API key (which is strange b/c it should be all set in GH). Hold tight!

@aulorbe
Copy link
Contributor

aulorbe commented Jun 21, 2024

Update: figured it out. The fork made for this request does not contain the necessary CI secrets. Author will open a branch (not a fork) and re-issue this PR.

@aulorbe aulorbe closed this Jun 21, 2024
@junefish junefish deleted the patch-1 branch June 21, 2024 20:44
@junefish junefish mentioned this pull request Jun 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants