-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for index_connection.go #38
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0b44a57
Update Justfile, rename components, add tests for toVector
aulorbe e09eaa6
Add toScoredVector tests
aulorbe cd0f7ee
Add vecToGrpc and sparseValToGrpc tests
aulorbe c5939b4
Add rest of tests
aulorbe 5599de7
Add new Justfile commands to allow running ind. tests
aulorbe cc6e201
Update go.sum file
aulorbe cef6e4c
Address comments
aulorbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,18 @@ test: | |
| source .env | ||
| set +o allexport | ||
| go test -count=1 -v ./pinecone | ||
| test-integration: | ||
| #!/usr/bin/env bash | ||
| set -o allexport | ||
| source .env | ||
| set +o allexport | ||
| go test -count=1 -v -run TestIntegrationClient ./pinecone | ||
| test-unit: | ||
| #!/usr/bin/env bash | ||
| set -o allexport | ||
| source .env | ||
| set +o allexport | ||
| go test -v -run Unit ./pinecone | ||
| bootstrap: | ||
| go install google.golang.org/protobuf/cmd/[email protected] | ||
| go install google.golang.org/grpc/cmd/[email protected] | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add
TestIntegrationIndexConnectionhere / can we? Wont this only run the client integration tests?See my comment here: https://github.com/pinecone-io/go-pinecone/pull/36/files#r1681345302