Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Filter to MetadataFilter for clarity #39

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

aulorbe
Copy link
Contributor

@aulorbe aulorbe commented Jul 16, 2024

Problem

Currently, Filter's function is confusing as it relates to Metadata (see this comment for more info).

Solution

Rename Filter to MetadataFilter to convey that it holds metadata that is used to constrain query-related requests.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

CI passes.

@aulorbe aulorbe requested a review from austin-denoble July 16, 2024 17:27
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🚢

@aulorbe aulorbe merged commit a5d8f62 into main Jul 16, 2024
3 checks passed
@aulorbe aulorbe deleted the Audrey/rename-filter branch July 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants