Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx README v1.0.0 #63

Merged
merged 1 commit into from
Aug 6, 2024
Merged

FIx README v1.0.0 #63

merged 1 commit into from
Aug 6, 2024

Conversation

austin-denoble
Copy link
Contributor

Problem

Missed completely removing the old metadata example in Query by Vector. Nice catch @jseldess.

Solution

Fix it.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

N/A

@austin-denoble austin-denoble requested a review from jseldess August 6, 2024 14:19
jseldess
jseldess approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austin-denoble austin-denoble merged commit 1abbeab into main Aug 6, 2024
3 checks passed
@austin-denoble austin-denoble deleted the adenoble/fix-metadata-readme branch August 6, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jseldess jseldess jseldess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austin-denoble @jseldess