Pass currentVersion
in release
workflow
#70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I tried running the new
release
action and it errored when trying to push tomain
and when generating the new version tag due to 3 things:main
branch doesn't allow pushes without PRs, we need to disable that to allow more flexibility from CI (we do this in the python and typescript repos).currentVersion
retrieved usinggit describe
was not being passed to thebump-version
action, so we ended up with NaN in the output.prereleaseSuffix
defaulting to "alpha1" and then being passed tobump-version
was an issue because it was being appended whether or notisPrerelease
was true.Failed run: https://github.com/pinecone-io/go-pinecone/actions/runs/10529783970/job/29178282163
Solution
SEMVER_VERSION
andPRERELEASE_SUFFIX
variables to therelease
workflow. Make sure these values are set in theget_tag_version
andset_prerelease_suffix
steps.currentVersion
value tobump-version
properly.Type of Change
Test Plan
Push changes up and rerun the version bump.