Regenerate client code for 2024-10
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-denoble
commented
Oct 23, 2024
pinecone/client.go
Outdated
| PodCount: int32(idx.Spec.Pod.Pods), | ||
| Replicas: idx.Spec.Pod.Replicas, | ||
| ShardCount: idx.Spec.Pod.Shards, | ||
| PodCount: derefOrDefault(idx.Spec.Pod.Pods, 0), |
There was a problem hiding this comment.
I don't think these should ever realistically be nil when coming back from the server.
There was a problem hiding this comment.
I agree... maybe the default should be 1 (as that's the count if all other defaults are used)
haruska
approved these changes
Oct 23, 2024
pinecone/client.go
Outdated
| PodCount: int32(idx.Spec.Pod.Pods), | ||
| Replicas: idx.Spec.Pod.Replicas, | ||
| ShardCount: idx.Spec.Pod.Shards, | ||
| PodCount: derefOrDefault(idx.Spec.Pod.Pods, 0), |
There was a problem hiding this comment.
I agree... maybe the default should be 1 (as that's the count if all other defaults are used)
austin-denoble
added a commit
that referenced
this pull request
Oct 23, 2024
## Problem PR was merged today making some slight adjustments to the db control spec to better align with the server impl: pinecone-io/apis#181 ## Solution Slightly adjust the `PodSpec` type and related code to account for the new shape. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan `just test` - CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR was merged today making some slight adjustments to the db control spec to better align with the server impl: https://github.com/pinecone-io/apis/pull/181
Solution
Slightly adjust the
PodSpectype and related code to account for the new shape.Type of Change
Test Plan
just test- CI