-
Notifications
You must be signed in to change notification settings - Fork 83
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Problem For managing Spruce artifacts I added a new command in the makefile, but I didn't update `.PHONY:` at the top of the file to include the new command. ## Solution - Add `upload-spruce` to `.PHONY:` in the Makefile. - Remove some unneeded `ids` from `release-spruce` and `nightly-spruce-dev-release`. ## Type of Change - [X] Bug fix (non-breaking change which fixes an issue) - [X] Infrastructure change (CI configs, etc) ## Test Plan Re-run workflows with corrected make.
- Loading branch information
1 parent
792b801
commit 3fccb12
Showing
3 changed files
with
1 addition
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,6 @@ jobs: | |
uses: andymckay/[email protected] | ||
|
||
- name: Set spruce dev version | ||
id: version | ||
run: | | ||
versionFile="pinecone/__version__" | ||
currentDate=$(date +%Y%m%d%H%M%S) | ||
|
@@ -58,7 +57,6 @@ jobs: | |
run: make package | ||
|
||
- name: Upload Python Spruce client to Test PyPI | ||
id: pypi_upload | ||
env: | ||
TWINE_REPOSITORY: testpypi | ||
PYPI_USERNAME: ${{ secrets.TEST_PYPI_USERNAME }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters