Skip to content

Commit

Permalink
Fix Spruce workflows (#217)
Browse files Browse the repository at this point in the history
## Problem
For managing Spruce artifacts I added a new command in the makefile, but
I didn't update `.PHONY:` at the top of the file to include the new
command.

## Solution
- Add `upload-spruce` to `.PHONY:` in the Makefile.
- Remove some unneeded `ids` from `release-spruce` and
`nightly-spruce-dev-release`.

## Type of Change
- [X] Bug fix (non-breaking change which fixes an issue)
- [X] Infrastructure change (CI configs, etc)

## Test Plan
Re-run workflows with corrected make.
  • Loading branch information
austin-denoble authored Oct 13, 2023
1 parent 792b801 commit 3fccb12
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/nightly-spruce-dev-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
uses: andymckay/[email protected]

- name: Set spruce dev version
id: version
run: |
versionFile="pinecone/__version__"
currentDate=$(date +%Y%m%d%H%M%S)
Expand All @@ -58,7 +57,6 @@ jobs:
run: make package

- name: Upload Python Spruce client to Test PyPI
id: pypi_upload
env:
TWINE_REPOSITORY: testpypi
PYPI_USERNAME: ${{ secrets.TEST_PYPI_USERNAME }}
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/release-spruce.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
ref: spruce

- name: Set spruce dev version
id: version
run: |
versionFile="pinecone/__version__"
currentDate=$(date +%Y%m%d%H%M%S)
Expand All @@ -45,7 +44,6 @@ jobs:
run: make package

- name: Upload Python Spruce client to Test PyPI
id: pypi_upload
env:
TWINE_REPOSITORY: testpypi
PYPI_USERNAME: ${{ secrets.TEST_PYPI_USERNAME }}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.PHONY: image develop tests tag-and-push docs version package upload license
.PHONY: image develop tests tag-and-push docs version package upload upload-spruce license
mkfile_path := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))

PYPI_USERNAME ?= __token__
Expand Down

0 comments on commit 3fccb12

Please sign in to comment.