-
Notifications
You must be signed in to change notification settings - Fork 89
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fix] Incorporate poetry changes into nightly build workflows (#225)
## Problem Nightly builds have not succeeded since poetry stuff got merged a couple of weeks ago. This is because the version update step was not updated to change the version number in pyproject.toml and pypi complained of version conflicts. ## Solution Use poetry to set version in `pyproject.toml` before uploading to pypi. ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [x] Infrastructure change (CI configs, etc)
- Loading branch information
Showing
2 changed files
with
19 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,14 +28,20 @@ jobs: | |
if: steps.list-commits.outputs.commits == '' | ||
uses: andymckay/[email protected] | ||
|
||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: 3.x | ||
|
||
- name: Setup Poetry | ||
uses: ./.github/actions/setup-poetry | ||
|
||
- name: Set dev version | ||
id: version | ||
run: | | ||
versionFile="pinecone/__version__" | ||
currentDate=$(date +%Y%m%d%H%M%S) | ||
versionNumber=$(cat $versionFile) | ||
versionNumber=$(poetry version -s) | ||
devVersion="${versionNumber}.dev${currentDate}" | ||
echo "$devVersion" > $versionFile | ||
poetry version $devVersion | ||
- name: Adjust module name | ||
run: | | ||
|
@@ -45,13 +51,6 @@ jobs: | |
run: | | ||
echo "This is a nightly developer build of the Pinecone Python client. It is not intended for production use." > README.md | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: 3.x | ||
|
||
- name: Setup Poetry | ||
uses: ./.github/actions/setup-poetry | ||
|
||
- name: Build Python client | ||
run: make package | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,13 +30,19 @@ jobs: | |
if: steps.list-commits.outputs.commits == '' | ||
uses: andymckay/[email protected] | ||
|
||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: 3.x | ||
|
||
- name: Setup Poetry | ||
uses: ./.github/actions/setup-poetry | ||
|
||
- name: Set spruce dev version | ||
run: | | ||
versionFile="pinecone/__version__" | ||
currentDate=$(date +%Y%m%d%H%M%S) | ||
versionNumber=$(cat $versionFile) | ||
devVersion="${versionNumber}.dev${currentDate}.spruceDev" | ||
echo "$devVersion" > $versionFile | ||
versionNumber=$(poetry version -s) | ||
devVersion="${versionNumber}.dev${currentDate}" | ||
poetry version $devVersion | ||
- name: Adjust module name | ||
run: | | ||
|
@@ -46,13 +52,6 @@ jobs: | |
run: | | ||
echo "This is a nightly Spruce developer build of the Pinecone Python client. It is not intended for production use." > README.md | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: 3.x | ||
|
||
- name: Setup Poetry | ||
uses: ./.github/actions/setup-poetry | ||
|
||
- name: Build Python client | ||
run: make package | ||
|
||
|