Skip to content

Commit

Permalink
Adjust googleapis-common-protos for protobuf compat
Browse files Browse the repository at this point in the history
  • Loading branch information
jhamon committed Dec 17, 2024
1 parent 0c0422b commit 5f5a5d1
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/testing-dependency.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
protoc-gen-openapiv2:
- 0.0.1
googleapis_common_protos_version:
- 1.62.0
- 1.63.0
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/test-dependency-grpc
Expand Down
2 changes: 1 addition & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ grpcio = [
{ version = ">=1.44.0", optional = true, python = "^3.8,<3.11" },
{ version = ">=1.59.0", optional = true, python = "^3.11" }
]
googleapis-common-protos = { version = ">=1.53.0", optional = true }
googleapis-common-protos = { version = ">=1.63.0", optional = true }
lz4 = { version = ">=3.1.3", optional = true }
protobuf = { version = "^5.28", optional = true }
protoc-gen-openapiv2 = {version = "^0.0.1", optional = true }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ def test_create_index_with_invalid_str_dimension(self, client, create_sl_index_p

def test_create_index_with_missing_dimension(self, client, create_sl_index_params):
del create_sl_index_params["dimension"]
with pytest.raises(TypeError):
with pytest.raises(PineconeApiException):
client.create_index(**create_sl_index_params)

0 comments on commit 5f5a5d1

Please sign in to comment.