Skip to content

Commit

Permalink
Update publish workflows with new testing setup (#266)
Browse files Browse the repository at this point in the history
## Problem

In #263 we split our tests across two different workflows. We need to
update our publishing workflows to find the test configurations in the
new locations.

## Solution

Replace references to `testing.yaml` with references to
`testing-grpc.yaml` and `testing-rest.yaml`.

## Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)
  • Loading branch information
jhamon authored Jan 10, 2024
1 parent 257ae25 commit 65343d5
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 9 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/alpha-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,18 @@ on:
default: 'rc1'

jobs:
testing:
uses: './.github/workflows/testing.yaml'
testing-rest:
uses: './.github/workflows/testing-rest.yaml'
secrets: inherit
testing-grpc:
uses: './.github/workflows/testing-grpc.yaml'
secrets: inherit

pypi:
uses: './.github/workflows/publish-to-pypi.yaml'
needs: testing
needs:
- testing-rest
- testing-grpc
with:
isPrerelease: true
ref: ${{ inputs.ref }}
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/nightly-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,17 @@ on:
- cron: '0 0 * * *'

jobs:
run-tests:
uses: './.github/workflows/testing.yaml'
testing-rest:
uses: './.github/workflows/testing-rest.yaml'
secrets: inherit
testing-grpc:
uses: './.github/workflows/testing-grpc.yaml'
secrets: inherit

pypi-nightly:
needs: run-tests
needs:
- testing-rest
- testing-grpc
timeout-minutes: 30
name: pypi-nightly
runs-on: ubuntu-latest
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,18 @@ on:
- 'major' # breaking changes

jobs:
testing:
uses: './.github/workflows/testing.yaml'
testing-rest:
uses: './.github/workflows/testing-rest.yaml'
secrets: inherit
testing-grpc:
uses: './.github/workflows/testing-grpc.yaml'
secrets: inherit

pypi:
uses: './.github/workflows/publish-to-pypi.yaml'
needs: testing
needs:
- testing-rest
- testing-grpc
with:
isPrerelease: false
ref: ${{ inputs.ref }}
Expand Down

0 comments on commit 65343d5

Please sign in to comment.