Prevent _get_api_instance from modifying OpenAPI config #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previous revision we added some code to apply a custom
host
value to control plane operations: #218This change caused 404s when calling dataplane operations. The
Configuration._base_path
value was being overwritten by the customhost
that was provided due to theConfiguration.host
setter:pinecone-python-client/pinecone/core/client/configuration.py
Line 493 in 7ff4ed8
Solution
The change I made was actually modifying the reference to
Config.OPENAPI_CONFIG
which overwrote things across the board.Instead of operating on the singleton's instance of the config, we can use
copy.deepcopy(Config.OPENAPI_CONFIG)
and use that to construct things before handing it off toApiClient
Type of Change
Test Plan
Pull this branch down, use the client locally and make sure that dataplane calls work properly without a
host
or with one in the case of supplying a custom control plane URL.